Fix Geizhals integration, use geizhalscrawler (#38123)#48593
Closed
neubi4 wants to merge 1 commit intohome-assistant:devfrom
Closed
Fix Geizhals integration, use geizhalscrawler (#38123)#48593neubi4 wants to merge 1 commit intohome-assistant:devfrom
neubi4 wants to merge 1 commit intohome-assistant:devfrom
Conversation
Contributor
probot-home-assistant
Bot
added
bugfix
dependency
frenck
reviewed
Apr 1, 2021
| "name": "Geizhals", | ||
| "documentation": "https://www.home-assistant.io/integrations/geizhals", | ||
| "requirements": ["geizhals==0.0.9"], | ||
| "requirements": ["geizhalscrawler==0.1"], |
Member
There was a problem hiding this comment.
This packages uses webscraping to gather information. This is not allowed and violated architectural decision record 0004 (ADR-0004).
Upstream code sample:
# parse prices
self.device.prices = []
for tmp in soup.select('div.offer__price .gh_price'):
matches = re.search(_REGEX, tmp.string)
raw = '{}.{}'.format(matches.group(1),
matches.group(2))
self.device.prices += [float(raw)]
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use the updated geizhalscrawler package as suggested in #38123 for the geizhals sensor (https://www.home-assistant.io/integrations/geizhals/) instead of the not working old package. The package "geizhals" is in read-only state and not maintained anymore.
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: